Switch RHEL10 default rootfs to erofs #1450
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change the squashfs-tools Requires to Recommends so that it will still be installed if it is available, and ignored if not. Add checks so that --squashfs-only now conflicts with --rootfs-type when using erofs. Also checks to make sure /usr/bin/mkfs.erofs is available, or /usr/sbin/mksquashfs is available when parsing the cmdline so it will exit early instead of running until rootfs creation fails without the right tools. Related: RHEL-48606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the default to erofs, makes squashfs-tools a Recommends (need to find out if that is ok to do with an unsupported package), and checks for the required tools early so you don't waste time if they aren't installed.