Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sbin usage #1449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove sbin usage #1449

wants to merge 1 commit into from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Jan 28, 2025

Fedora 42 has merged /usr/bin and /usr/sbin
https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin

This moves all of the lorax executables into bin, adjusts all the uses of sbin including some tests, and some called by lorax and livemedia-creator. These are now discovered using shutil.which instead of being hard-coded.

It also removes checking for linker problems /usr/sbin since that would just double the scan time.

Fedora 42 has merged /usr/bin and /usr/sbin
https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin

This moves all of the lorax executables into bin, adjusts all the uses
of sbin including some tests, and some called by lorax and
livemedia-creator. These are now discovered using shutil.which instead
of being hard-coded.

It also removes checking for linker problems /usr/sbin since that would
just double the scan time.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13021163488

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 43.437%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pylorax/treebuilder.py 0 1 0.0%
src/pylorax/creator.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/pylorax/init.py 1 17.31%
Totals Coverage Status
Change from base Build 12698732580: -0.03%
Covered Lines: 1635
Relevant Lines: 3562

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants