Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates in template files regarding to the default fonts packages #1375

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

tagoh
Copy link
Contributor

@tagoh tagoh commented Feb 6, 2024

Current font packages list in template is a bit outdated. This PR aims to update it.

Replace specific font package names with default fonts
meta packages except default-fonts-cjk-sans.

default-fonts-cjk-sans pulls google-noto-sans-cjk-vf-fonts at this moment
though, it is too big compared to google-noto-sans-cjk-fonts even after
removing unnecessary variants of font files.
It is very unfortunate but we can't go with it.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7794371235

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.543%

Totals Coverage Status
Change from base Build 7750295129: 0.0%
Covered Lines: 1614
Relevant Lines: 3500

💛 - Coveralls

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bcl bcl merged commit 3ad18bf into weldr:master Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants