Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes tsne.coords Matrix slot to dr.coords list slot to store t-SNE and UMAP coords in the same object. #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changes tsne.coords Matrix slot to dr.coords list slot to store t-SNE and UMAP coords in the same object. #94

wants to merge 2 commits into from

Conversation

jsodicoff
Copy link
Collaborator

No description provided.

@vkozareva
Copy link
Collaborator

The build errors so far are due to old tests referring to the now nonexistent tsne.coords. Don't forget to update existing tests to be compatible with your new features (in this case, the new dr.coord slot)!
Also, many of the same notes from #89 apply here too -- make sure to check the build log.

@vkozareva
Copy link
Collaborator

Also, you'll need to merge master back into this feature branch and fix the merge conflicts indicated above!

@samuel-marsh samuel-marsh mentioned this pull request May 28, 2020
Closed
@samuel-marsh samuel-marsh mentioned this pull request Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsodicoff @vkozareva