Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade bb8 to v9.0 #204

Merged
merged 2 commits into from
Dec 19, 2024
Merged

chore: upgrade bb8 to v9.0 #204

merged 2 commits into from
Dec 19, 2024

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Dec 16, 2024

bb8 v9.0 dropped async_trait and bumped MSRV to v1.75.0 which is already compatible with this library's MSRV v1.78.0.

weiznich
weiznich requested changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR. The actual change itself look good, although the formatting related changes (mostly the imports) shouldn't be in here.

weiznich
weiznich approved these changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the fast fix

@weiznich weiznich merged commit c7569a5 into weiznich:main Dec 19, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiznich weiznich weiznich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabify @weiznich