-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version update #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add final release rule and omit the pre_l and pre_n parts
bd7d391
to
d6b58ac
Compare
@ethanwhite do you think we should amend/squash the second commit or leave it in the history? |
No strong feelings. It's a weird situation. Whatever you think is best is good by me |
d6b58ac
to
96af35c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I install this PR and check for the version in Python I get an error:
import deepforest
deepforest.__version__
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[2], line 1
----> 1 deepforest.__version__
AttributeError: module 'deepforest' has no attribute '__version__'
This works as it should in 1.3.3. I'm not sure if the issue in in this PR elsewhere, but we should fix it here.
@ethanwhite with the current structure we have >>> from deepforest._version import __version__
>>> __version__
'1.4.1' |
Is that a new Python standard? |
I'm booked most of the afternoon so @henrykironde just go with what you think is best. My thinking was based on https://stackoverflow.com/questions/458550/standard-way-to-embed-version-into-python-package But if that has changed I'm fine with doing it differently. I'm going to change to Approve so that I'm not blocking you and @bw4sz finishing off the release |
010f027
to
8c3608f
Compare
8c3608f
to
d152087
Compare
Ubuntu 24.04 has some bugs at the moment
No description provided.