Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version update #804

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Conversation

henrykironde
Copy link
Contributor

No description provided.

Copy link
Member

@ethanwhite ethanwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanwhite ethanwhite changed the title Release verion update Release version update Oct 10, 2024
@henrykironde
Copy link
Contributor Author

@ethanwhite do you think we should amend/squash the second commit or leave it in the history?

@ethanwhite
Copy link
Member

@ethanwhite do you think we should amend/squash the second commit or leave it in the history?

No strong feelings. It's a weird situation. Whatever you think is best is good by me

Copy link
Member

@ethanwhite ethanwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I install this PR and check for the version in Python I get an error:

import deepforest
deepforest.__version__
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[2], line 1
----> 1 deepforest.__version__

AttributeError: module 'deepforest' has no attribute '__version__'

This works as it should in 1.3.3. I'm not sure if the issue in in this PR elsewhere, but we should fix it here.

@henrykironde
Copy link
Contributor Author

@ethanwhite with the current structure we have

>>> from deepforest._version import __version__
>>> __version__
'1.4.1'

@ethanwhite
Copy link
Member

Is that a new Python standard?

@ethanwhite
Copy link
Member

I'm booked most of the afternoon so @henrykironde just go with what you think is best. My thinking was based on deepforest.__version__ being a de facto standard:

https://stackoverflow.com/questions/458550/standard-way-to-embed-version-into-python-package

But if that has changed I'm fine with doing it differently. I'm going to change to Approve so that I'm not blocking you and @bw4sz finishing off the release

Ubuntu 24.04 has some bugs at the moment
@henrykironde henrykironde merged commit 99d0cfb into weecology:main Oct 14, 2024
6 checks passed
@henrykironde henrykironde deleted the bumpversion branch October 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants