Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add the cross-env package to dependencies #301

Closed
wants to merge 5 commits into from

Conversation

timor-m
Copy link

@timor-m timor-m commented Jan 5, 2024

add the cross-env package to dependencies

[√ ] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • [√ ] Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[√ ] No

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 5, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 5, 2024

CLA assistant check
All committers have signed the CLA.

@timor-m
Copy link
Author

timor-m commented Jan 5, 2024

@huan Can you review it for me when you have time?

@huan
Copy link
Member

huan commented Jan 5, 2024

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.
  2. The PR has passed all the CI tests and turns green. (you can execute all tests locally by running npm test)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 6, 2024
@timor-m
Copy link
Author

timor-m commented Jan 6, 2024

@huan
Thank you for your reply.
The CLA has been completed, but the github actions test has not yet been completed.

@huan
Copy link
Member

huan commented May 8, 2024

Hi @timor-m , I think the cross-env and npm-run-all will be installed even without the direct dependencies. Please correct me if I'm wrong.

This PR includes many unrelated changes, including the version upgrade. Upgrading the version to the latest stable version is great, but the best practice would be to create a separate PR to do that.

I will close this PR for now, and you are welcome to create an new one by following the best practices.

@huan huan closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants