-
-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restyle commit #106
restyle commit #106
Conversation
added footer and basic animation for hiding/showing torrent download form: animation used: https://gist.github.com/chrisbuttery/cf34533cbb30c95ff155 |
|
||
// https://gist.github.com/chrisbuttery/cf34533cbb30c95ff155 | ||
exports.fadeOut = function fadeOut (el) { | ||
el.style.opacity = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remove this semi-colon it causes an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imprecation Check out these rules from standard js: https://github.com/feross/standard/blob/master/RULES.md#semicolons
I'm really busy right now -- will check this out when I get a chance. Thanks for sending! |
@imprecation I've just installed your restyled version of Instant.io. Well done, nice design, i love it! |
Thanks for the PR @imprecation, but I'm going to use a design based on Google's Material design for this. I know it's a bummer that I'm not going to merge this, but I really appreciate the work you put into this. Thanks again! |
restyle referenced:
https://github.com/feross/instant.io/issues/17#issuecomment-111589349
it uses font-awesome for 3 glyphs (github, upload icon and the rocket) and google fonts for fonts Poiret One and Lato.