audio demo: also support outbound-rtp in addition to outboundrtp #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason I thought you deleted outboundrtp and added outbound-rtp??? I wonder why :) Anyway LGTM. |
KaptenJansson
added a commit
that referenced
this pull request
Sep 1, 2015
audio demo: also support outbound-rtp in addition to outboundrtp
|
The right one is "outboundrtp" AFAIK. |
|
well, we currently have one not-yet-compliant browser so having another one doesn't hurt :-) |
|
Yes, hopefully this will make it to a stats shim some day ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure what the plan is WRT to outbound-rtp vs outboundrtp. The former is used by webrtc-pc and ortc, the latter by webrtc-stats. Either way, this should make things work, we can remove the wrong types at some point in the future :-)