move codec selection to the receiver for more samples #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow-up to webrtc#1640 which got copy-pasted quite a bit.
fippo
force-pushed
the
setcodecpreferences-woes
branch
from
f3bed9a to
00bdcc3
Compare
alvestrand
approved these changes
Nov 25, 2023
| transceiver.setCodecPreferences(codecs); | ||
| if ('setCodecPreferences' in window.RTCRtpTransceiver.prototype) { | ||
| this.pc2.ontrack = (e) => { | ||
| if (e.track.kind === 'audio' && preferredAudioCodecMimeType ) { |
There was a problem hiding this comment.
Hm. From surrounding text, it looks as if this should be a handler function, not an innate property of VideoPipe.
But that's a different refactoring from this one, so not a showstopper.
There was a problem hiding this comment.
The good news is that we can now actually move it to the outside ontrack handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #1640 which got copy-pasted quite a bit.