Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index generation system that uses offsets into the WACZ itself. #38

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anjackson
Copy link

@anjackson anjackson commented Sep 13, 2023

This proposed new py-wacz command allows you to generate a CDXJ file where the filenames and offsets refer to the WACZ itself rather than the WARC files within.

The idea is that we should be able to store the WACZ files directly without unpacking them, and use this modified CDXJ data to ingest into OutbackCDX. This should mean we can play back WACZ files as easily as we can WARCs.

Currently DRAFT:

  • In case I've missed something and this is a terrible idea?
  • Because perhaps the operation should be given a different name than just 'index'? Not sure it's the best name.
  • Because it needs a way to override the path prefix, and possibly even the actual WACZ name, depending on the use case.
  • And it should probably have some tests!

@edsu
Copy link
Collaborator

edsu commented Sep 19, 2023

This is a pretty ingenious idea!

@anjackson
Copy link
Author

The CI errors don't seem to be related to my patch?

pydantic.errors.PydanticUserError: A non-annotated attribute was detected: `version = '0.1.0'`. All model fields require a type annotation; if `version` is not meant to be a field, you may be able to resolve this error by annotating it as a `ClassVar` or updating `model_config['ignored_types']`.

Not sure what to do about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants