Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate exclusion regex on add #2316

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Validate exclusion regex on add #2316

merged 11 commits into from
Jan 23, 2025

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Jan 16, 2025

Fixes #2227

@tw4l tw4l marked this pull request as ready for review January 16, 2025 19:07
@tw4l tw4l requested a review from ikreymer January 16, 2025 19:07
@ikreymer
Copy link
Member

We also want to validate when creating / updating a workflow

@tw4l
Copy link
Member Author

tw4l commented Jan 17, 2025

@ikreymer should be good now!

@ikreymer
Copy link
Member

Confirmed that it works on backend, however, the invalid regex notification is hard to see. Though, that may be addressed via #2310

@tw4l tw4l merged commit 9363095 into main Jan 23, 2025
22 checks passed
@tw4l tw4l deleted the issue-2227-regex-validation branch January 23, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Able to submit invalid regex exclusion
2 participants
@tw4l @ikreymer