Ensure partial responses are not written #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: prefer streaming current response via takeStream, not only when size is unknown - ensure partial range requests are not async fetched, only full responses - don't serialize zero-payload responses - don't serialize 206 responses if there is size mismatch
…nstead of via size check
|
Merging for now so can do a 1.4.0-beta.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various fixes for streaming, especially related to range requests
Fixes capture of YT videos, for example on: https://www.thejazzpianosite.com/jazz-piano-lessons/jazz-scales/melodic-minor-modes/ that otherwise resulted in partial videos being stored.