Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARC-Protocol + WARC-Cipher-Suite headers #715

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WARC-Protocol + WARC-Cipher-Suite headers #715

wants to merge 2 commits into from

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 7, 2024 •
edited
Loading

A few caveats:

  • The WARC-Cipher-Suite data is not directly available from the browser, so must be inferred based on the available info.
  • The WARC-Protocol header is comma separated, instead of as two entries - need to clarify that this is alright.
  • Needs tests.

@ikreymer
- add WARC-Protocol header combining http + tls protocols as comma se…
ab45429 
…parated

- add WARC-Cipher-Suite header, mapping Chrome NetworkSecurityDetails to known cipher suites
- fixes #641
@ikreymer
cleanup, add fallbacks for tls/1.3 to common cipher values
764930b
@tw4l
Copy link
Member

tw4l commented Nov 11, 2024

Re: the WARC-Protocol header being comma separated rather than repeated, it looks like the IIPC membership is trying to get consensus on whether this is acceptable this week. See ongoing discussion here: iipc/warc-specifications#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for WARC-Protocol and WARC-Cipher-Suite headers
2 participants
@ikreymer @tw4l