Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression in 0.12.x for app: #239

Merged
merged 1 commit into from
Jul 7, 2024
Merged

fix regression in 0.12.x for app: #239

merged 1 commit into from
Jul 7, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Jul 7, 2024 •
edited
Loading

@ikreymer
fix regression in 0.12.x for app:
25aba0b 
- still need to register service worker if in app
- update checkSW() to check if no service worker and register on load
- in extension, service worker always provided by system
- fixes #234, #233, #232, #231, related to #217
@ikreymer ikreymer merged commit 7c16857 into main Jul 7, 2024
2 of 3 checks passed
@ikreymer ikreymer deleted the register-sw-for-app branch July 7, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ArchiveWebpage Desktop hangs in New Archiving Session
1 participant
@ikreymer