Use @benthemonkey source-map fork #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need published package... |
|
Yeah, repo can be deleted. |
|
Sure I'll do this today. |
|
Let's change it in |
|
@benthemonkey thanks for the rapid feedback! @alexander-akait it's done |
|
I think it's ready, but let's wait for benthemonkey/source-map#1. I will try to polish and release it this weekend. |
|
@7rulnik thanks for fixing it |
|
@7rulnik feel free to ping me when it will be ready |
|
@alexander-akait I finished optimizations and moved to https://www.npmjs.com/package/source-map-js For more info see 7rulnik/source-map-js#2 As a result, parsing became 4x faster and serialization 30% faster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benthemonkey made a
source-mapfork and backported mozilla/source-map#308 to js implementation.Patch diff: mozilla/source-map@0.6.1...benthemonkey:patch-0.6.1
Sources of the idea:
mozilla/source-map#370
zulip/zulip#16545
Related to #34
I tried to run the benchmark in webpack repo but got jest error
Your test suite must contain at least one test. Also, there is some problem with Travis, but tests passed on my machine.