Skip to content

feat: overhaul of overlay UI #5441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

negimox
Copy link
Contributor

@negimox negimox commented Mar 22, 2025

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No ( Already exists )

Motivation / Use-Case

Modified and improved the overlay UI according to #3689

Breaking Changes

Additional Info

webpack_dev_feat_overlay-2025-03-23_03.09.36.mp4

@negimox
Copy link
Contributor Author

negimox commented Mar 22, 2025

Hello, @alexander-akait @snitin315 can you check if this change suits issue #3689 ?

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 8.38323% with 153 lines in your changes missing coverage. Please review.

Project coverage is 58.11%. Comparing base (af6bd68) to head (9a9305e).
Report is 120 commits behind head on master.

Files with missing lines Patch % Lines
client-src/overlay.js 8.38% 134 Missing and 19 partials ⚠️

❗ There is a different number of reports uploaded between BASE (af6bd68) and HEAD (9a9305e). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (af6bd68) HEAD (9a9305e)
36 10
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5441       +/-   ##
===========================================
- Coverage   90.29%   58.11%   -32.19%     
===========================================
  Files          15       13        -2     
  Lines        1577     2139      +562     
  Branches      601      768      +167     
===========================================
- Hits         1424     1243      -181     
- Misses        140      748      +608     
- Partials       13      148      +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test cases.

You remove:

containerElement.innerHTML = overlayTrustedTypesPolicy
        ? overlayTrustedTypesPolicy.createHTML("")
        : "";

But in some part of code you use something.innerHTML= "html", you need to use the same logic as you remove, otherwise trusted police will be broken

Also does it work for warnings too?

@alexander-akait
Copy link
Member

Anyway code looks good, let's fix the problems above

@negimox
Copy link
Contributor Author

negimox commented Mar 28, 2025

Hello, @alexander-akait. I have modified the code according to the above suggestions. can you verify if it is sufficient?

@negimox negimox requested a review from alexander-akait April 23, 2025 18:12
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the same test but with TrustedTypesPolicy to ensure we don't break something and we can merge, thank you for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants