-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: overhaul of overlay UI #5441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hello, @alexander-akait @snitin315 can you check if this change suits issue #3689 ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5441 +/- ##
===========================================
- Coverage 90.29% 58.11% -32.19%
===========================================
Files 15 13 -2
Lines 1577 2139 +562
Branches 601 768 +167
===========================================
- Hits 1424 1243 -181
- Misses 140 748 +608
- Partials 13 148 +135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test cases.
You remove:
containerElement.innerHTML = overlayTrustedTypesPolicy
? overlayTrustedTypesPolicy.createHTML("")
: "";
But in some part of code you use something.innerHTML= "html"
, you need to use the same logic as you remove, otherwise trusted police will be broken
Also does it work for warnings too?
Anyway code looks good, let's fix the problems above |
Hello, @alexander-akait. I have modified the code according to the above suggestions. can you verify if it is sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the same test but with TrustedTypesPolicy
to ensure we don't break something and we can merge, thank you for your work
For Bugs and Features; did you add new tests?
No ( Already exists )
Motivation / Use-Case
Modified and improved the overlay UI according to #3689
Breaking Changes
Additional Info
webpack_dev_feat_overlay-2025-03-23_03.09.36.mp4