Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prerequisites.sh: Don't fail if lsb_release executable missing #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prerequisites.sh: Don't fail if lsb_release executable missing #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/prerequisites.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,10 @@ essential="\
wget \
"

# add python3-distutils only for 18.04 (and later should be added for newer)
# add python3-distutils only for 18.04 and later
# because it doesn't exist as separate package in older Ubuntu releases
[ `/usr/bin/lsb_release -s -r` = "18.04" ] && essential="${essential} python3-distutils"
release_numerical=$(echo "$release" | tr -d .)
[ -n "$release" ] && [ "$release_numerical" -ge "1804" ] && essential="${essential} python3-distutils"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from myself: It might look nicer to use a real if-statement here, but I just continued with the style that was already used here. (I also write expressions like this in my own scripts because it is efficient.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the missing quote. Bugfixed and force-pushed now.


# bzip2, gzip, tar, zip are used by our scripts/build.sh
archivers="\
Expand Down