Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema built from SDL to return null for unknown types #1068

Merged
merged 8 commits into from
Feb 15, 2022
Merged

Fix schema built from SDL to return null for unknown types #1068

merged 8 commits into from
Feb 15, 2022

Commits on Feb 12, 2022

  1. Add (failing) tests for Schema::getType() 

    `Schema::getType()` should return `null` if the requested type doesn't exist in the schema.
Works correctly for a schema created using type definitions but fails for a schema built from SDL.
    @vhenzl
    vhenzl committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    3a2566e View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2022

  1. Fix schema built from SDL to return null for non-existent types

    @vhenzl
    vhenzl committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    f29df49 View commit details
    Browse the repository at this point in the history

  2. Remove temporary buildTypeFrom*() methods

    @vhenzl
    vhenzl committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    229477d View commit details
    Browse the repository at this point in the history

  3. Remove temporary TODOs

    @vhenzl
    vhenzl committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    cbf9916 View commit details
    Browse the repository at this point in the history

  4. Simplify code with maybeBuildType()

    @vhenzl
    vhenzl committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    97f711e View commit details
    Browse the repository at this point in the history

  5. Add changelog

    @vhenzl
    vhenzl committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    d873e15 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Merge branch 'master' into fix-schema-gettype

    @vhenzl
    vhenzl committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    d971695 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Multiline ternary

    @spawnia
    spawnia authored Feb 15, 2022
    Configuration menu
    Copy the full SHA
    ced3095 View commit details
    Browse the repository at this point in the history