Skip to content

Commit

Permalink
fix aarch64 realtime-only build
Browse files Browse the repository at this point in the history
After the additions of vp9_temporal_filter_neon_dotprod.c and
vp9_temporal_filter_neon_i8mm.c. These are only used needed in
non-realtime-only builds. Fixes:

vp9/encoder/arm/neon/vp9_temporal_filter_neon_dotprod.c:82:5: error:
  call to undeclared function 'vpx_convolve12_horiz_c'; ISO C99 and
  later do not support implicit function declarations
  [-Wimplicit-function-declaration]
    vpx_convolve12_horiz_c(src, src_stride, dst, dst_stride, filter, x0_q4,
    ^
vp9/encoder/arm/neon/vp9_temporal_filter_neon_dotprod.c:75:6: warning:
  no previous prototype for function 'vpx_convolve12_horiz_neon_dotprod'
  [-Wmissing-prototypes]
void vpx_convolve12_horiz_neon_dotprod(const uint8_t *src, ptrdiff_t src_stride,

...

vp9/encoder/arm/neon/vp9_temporal_filter_neon_i8mm.c:71:5: error: call
  to undeclared function 'vpx_convolve12_horiz_c'; ISO C99 and later do
  not support implicit function declarations
  [-Wimplicit-function-declaration]
    vpx_convolve12_horiz_c(src, src_stride, dst, dst_stride, filter, x0_q4,
    ^
vp9/encoder/arm/neon/vp9_temporal_filter_neon_i8mm.c:64:6: warning: no
  previous prototype for function 'vpx_convolve12_horiz_neon_i8mm'
  [-Wmissing-prototypes]

Change-Id: Ie9a701ade64eaec2a7759f59f38799ee9ea98b5d
  • Loading branch information
jzern committed Jan 9, 2025
1 parent dbd0d11 commit 7a65480
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions vp9/vp9cx.mk
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/x86/highbd_temporal_filter
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/x86/highbd_temporal_filter_sse4.c
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/x86/highbd_temporal_filter_avx2.c
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/arm/neon/vp9_temporal_filter_neon.c
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/arm/neon/vp9_temporal_filter_neon_dotprod.c
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/arm/neon/vp9_temporal_filter_neon_i8mm.c
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/arm/neon/vp9_highbd_temporal_filter_neon.c
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/vp9_alt_ref_aq.h
VP9_CX_SRCS_REMOVE-$(CONFIG_REALTIME_ONLY) += encoder/vp9_alt_ref_aq.c
Expand Down

0 comments on commit 7a65480

Please sign in to comment.