Add lending calendar #5586
Add lending calendar #5586
Conversation
Bestem0r
force-pushed
the
add-lending-calendar
branch
from
674950c to
90cce6b
Compare
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-05-22 14:26:13 CET |
| <Card> | ||
| <Flex column gap="var(--spacing-md)"> | ||
| <h3>Ny forespørsel</h3> | ||
| <LendingRequestEditor onRangeChange={setRange} /> | ||
| </Flex> | ||
| </Card> |
There was a problem hiding this comment.
I think it looks better when the new request form is inside it's own container, separate from the calendar
| onChange={(value: [Dateish, Dateish]) => { | ||
| if (onRangeChange && value && value.length === 2) { | ||
| onRangeChange(value); | ||
| } | ||
| }} |
There was a problem hiding this comment.
what is this? Should this logic not be added to the date picker itself?
There was a problem hiding this comment.
Yeah the plan is to use the calendar as the actual date picker in the next iteration if that's what you mean
| lendableObjectId, | ||
| selectedRange, | ||
| }: LendingCalendarProps) => { | ||
| const [currentMonth, setCurrentMonth] = useState(moment()); |
There was a problem hiding this comment.
it says current month but it stores the current day? not sure if intentional?
There was a problem hiding this comment.
The stored day is only used to track which month (and year) the calendar should display, that's why I called it month and not day. Can change it though
|
|
||
| .dayCell { | ||
| vertical-align: top; | ||
| padding: 0 !important; |
Description
Adds a calendar to show unavailable time slots given a lendable object, as well the time slots chosen for the current lending request. The calendar is added to both the new lending request and lending request detail pages.
Next step will be to make the calendar function as the date and time picker for new lending requests.
Backend PR
Result
Screencast.From.2025-05-20.00-06-10.online-video-cutter.com.mp4
Testing
Create and approve a lending request. Verify that the calendar displays unavailable and selected time slots correctly.
Resolves ABA-1438