Skip to content

Commit

Permalink
Add initial Towncrier integration
Browse files Browse the repository at this point in the history
  • Loading branch information
webknjaz committed Dec 20, 2021
1 parent 9362e44 commit f7b4ca3
Show file tree
Hide file tree
Showing 12 changed files with 317 additions and 1 deletion.
11 changes: 11 additions & 0 deletions .github/chronographer.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
enforce_name:
suffix: .md
exclude:
bots:
- dependabot-preview
- dependabot
- patchback
humans:
- pyup-bot
...
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Changelog

[//]: # (DO-NOT-REMOVE-versioning-promise-START)

```{note}
The change notes follow [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
except for the title formatting, and this project adheres to [Semantic
Versioning](https://semver.org/spec/v2.0.0.html).
```

<!--
Do *NOT* manually add changelog entries here!
This changelog is managed by Towncrier and is built at release time.
See https://myst-parser.rtfd.io/en/latest/develop/contributing#adding-change-notes-with-your-prs
for details. Or read
https://github.com/executablebooks/MyST-Parser/tree/master/docs/changelog-fragments.d#adding-change-notes-with-your-prs
-->

<!-- towncrier release notes start -->

## 0.16.1 - 2021-12-16

✨ NEW: Add `myst_linkify_fuzzy_links` option.
Expand Down
31 changes: 31 additions & 0 deletions docs/changelog-fragments.d/.CHANGELOG-TEMPLATE.md.j2
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@

{% for section, _ in sections.items() %}
{% set title_prefix = underlines[0] %}
{% if section %}
{{ title_prefix }} {{ section }}
{% set title_prefix = underlines[1] %}
{% endif %}

{% if sections[section] %}
{% for category, val in definitions.items() if category in sections[section] %}
{{ title_prefix }} {{ definitions[category]['name'] }}
{% if definitions[category]['showcontent'] %}

{% for text, values in sections[section][category].items() %}
* {{ text }}
({{ values|join(',\n ') }})
{% endfor -%}

{% else %}
* {{ sections[section][category]['']|join(', ') }}
{% endif %}

{% if sections[section][category]|length == 0 %}
No significant changes.
{% endif %}
{% endfor %}

{% else %}
No significant changes.
{% endif %}
{% endfor %}
25 changes: 25 additions & 0 deletions docs/changelog-fragments.d/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
*
!.CHANGELOG-TEMPLATE.md.j2
!.gitignore
!README.md
!*.bugfix
!*.bugfix.md
!*.bugfix.*.md
!*.breaking
!*.breaking.md
!*.breaking.*.md
!*.deprecation
!*.deprecation.md
!*.deprecation.*.md
!*.doc
!*.doc.md
!*.doc.*.md
!*.feature
!*.feature.md
!*.feature.*.md
!*.internal
!*.internal.md
!*.internal.*.md
!*.misc
!*.misc.md
!*.misc.*.md
4 changes: 4 additions & 0 deletions docs/changelog-fragments.d/454.misc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Added changelog fragment management infrastructure using [Towncrier]
-- by {user}`webknjaz`

[Towncrier]: https://github.com/twisted/towncrier
79 changes: 79 additions & 0 deletions docs/changelog-fragments.d/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<!-- markdownlint-disable first-line-heading -->

(_myst_parser_adding_changelog_fragments)=

## Adding change notes with your PRs

It is very important to maintain a log for news of how
updating to the new version of the software will affect
end-users. This is why we enforce collection of the change
fragment files in pull requests as per [Towncrier philosophy].

The idea is that when somebody makes a change, they must record
the bits that would affect end-users only including information
that would be useful to them. Then, when the maintainers publish
a new release, they'll automatically use these records to compose
a change log for the respective version. It is important to
understand that including unnecessary low-level implementation
related details generates noise that is not particularly useful
to the end-users most of the time. And so such details should be
recorded in the Git history rather than a changelog.

## Alright! So how do I add a news fragment?

To submit a change note about your PR, add a text file into the
`docs/changelog-fragments.d/` folder. It should contain an
explanation of what applying this PR will change in the way
end-users interact with the project. One sentence is usually
enough but feel free to add as many details as you feel necessary
for the users to understand what it means.

**Use the past tense** for the text in your fragment because,
combined with others, it will be a part of the "news digest"
telling the readers **what changed** in a specific version of
the library *since the previous version*. You should also use
[MyST Markdown] syntax for highlighting code (inline or block),
linking parts of the docs or external sites.
At the end, sign your change note by adding ```-- by
{user}`github-username``` (replace `github-username` with
your own!).

Finally, name your file following the convention that Towncrier
understands: it should start with the number of an issue or a
PR followed by a dot, then add a patch type, like `feature`,
`bugfix`, `doc`, `misc` etc., and add `.md` as a suffix. If you
need to add more than one fragment, you may add an optional
sequence number (delimited with another period) between the type
and the suffix.

## Examples for changelog entries adding to your Pull Requests

File `docs/changelog-fragments.d/666.doc.md`:

```md
Added a `{user}` role to Sphinx config -- by {user}`webknjaz`
```

File `docs/changelog-fragments.d/116.feature.md`:

```md
Added support for nested module options (suboptions)
-- by {user}`tomaciazek`
```

File `docs/changelog-fragments.d/140.bugfix.md`:

```md
Implemented opening standalone Ansible files that have no workspace
associated -- by {user}`ganeshrn`
```

```{tip}
See `pyproject.toml` for all available categories
(`tool.towncrier.type`).
```

[MyST Markdown]:
https://myst-parser.rtfd.io/en/latest/syntax/syntax.html
[Towncrier philosophy]:
https://towncrier.rtfd.io/en/actual-freaking-docs/#philosophy
45 changes: 44 additions & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,31 @@
# list see the documentation:
# https://www.sphinx-doc.org/en/master/usage/configuration.html

from pathlib import Path

from sphinx.application import Sphinx
from sphinx.util.docutils import SphinxDirective

from myst_parser import __version__


# -- Path setup --------------------------------------------------------------

PROJECT_ROOT_DIR = Path(__file__).parents[1].resolve() # pylint: disable=no-member
# -- Project information -----------------------------------------------------

github_url = 'https://github.com'
github_repo_org = 'ansible'
github_repo_name = 'ansible-language-server'
github_repo_slug = f'{github_repo_org}/{github_repo_name}'
github_repo_url = f'{github_url}/{github_repo_slug}'
github_sponsors_url = f'{github_url}/sponsors'

project = "MyST Parser"
copyright = "2020, Executable Book Project"
author = "Executable Book Project"
version = __version__
release = version # FIXME: generate full version w/ setuptools-scm

master_doc = "index"
language = "en"
Expand All @@ -27,13 +41,15 @@
extensions = [
"myst_parser",
"sphinx.ext.autodoc",
'sphinx.ext.extlinks',
"sphinx.ext.intersphinx",
"sphinx.ext.viewcode",
"sphinxcontrib.bibtex",
"sphinx_panels",
"sphinxext.rediraffe",
"sphinxcontrib.mermaid",
"sphinxext.opengraph",
'sphinxcontrib.towncrier', # provides `towncrier-draft-entries` directive
]

# Add any paths that contain templates here, relative to this directory.
Expand All @@ -42,7 +58,10 @@
# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
# This pattern also affects html_static_path and html_extra_path.
exclude_patterns = ["_build", "Thumbs.db", ".DS_Store"]
exclude_patterns = [
"_build", "Thumbs.db", ".DS_Store",
'changelog-fragments.d/**', # Towncrier-managed change notes
]


# -- Options for HTML output -------------------------------------------------
Expand Down Expand Up @@ -88,6 +107,12 @@
"substitution",
"tasklist",
]
myst_substitutions = {
'project': project,
'release': release,
'release_l': f'`{release}`', # Needed in draft changelog for spelling ext
'version': version,
}
myst_heading_anchors = 2
myst_footnote_transition = True
myst_dmath_double_inline = True
Expand All @@ -102,6 +127,14 @@
}


# -- Options for towncrier_draft extension -----------------------------------

towncrier_draft_autoversion_mode = 'draft' # or: 'sphinx-version', 'sphinx-release'
towncrier_draft_include_empty = True
towncrier_draft_working_directory = PROJECT_ROOT_DIR
# Not yet supported: towncrier_draft_config_path = 'pyproject.toml' # relative to cwd


def run_apidoc(app):
"""generate apidoc
Expand Down Expand Up @@ -137,6 +170,16 @@ def run_apidoc(app):
os.remove(os.path.join(api_folder, "modules.rst"))


# -- Options for extlinks extension ------------------------------------------

extlinks = {
'issue': (f'{github_repo_url}/issues/%s', '#'), # noqa: WPS323
'pr': (f'{github_repo_url}/pull/%s', 'PR #'), # noqa: WPS323
'commit': (f'{github_repo_url}/commit/%s', ''), # noqa: WPS323
'gh': (f'{github_url}/%s', 'GitHub: '), # noqa: WPS323
'user': (f'{github_sponsors_url}/%s', '@'), # noqa: WPS323
}

intersphinx_mapping = {
"python": ("https://docs.python.org/3.7", None),
"sphinx": ("https://www.sphinx-doc.org/en/master", None),
Expand Down
19 changes: 19 additions & 0 deletions docs/develop/_changelog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,23 @@
# Changelog

```{include} ../../CHANGELOG.md
:end-before: <!-- towncrier release notes start -->
:start-after: (DO-NOT-REMOVE-versioning-promise-START)
```

<!-- markdownlint-disable-next-line no-space-in-emphasis -->
## {{ release_l }}, as of {sub-ref}`today` _{subscript}`/UNRELEASED DRAFT/`_

```{important} This version is not yet released and is under active development
```

```{towncrier-draft-entries}
```

```{include} ../../CHANGELOG.md
:relative-docs: docs/
:relative-images:
:start-after: <!-- towncrier release notes start -->
```
3 changes: 3 additions & 0 deletions docs/develop/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ For documentation build tests:
>> make html-strict
```

```{include} ../changelog-fragments.d/README.md
```

```{seealso}
{ref}`develop/testing`
```
Expand Down
47 changes: 47 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,50 @@ known_first_party = ["myst_parser", "tests"]
known_third_party = ["docutils", "markdown_it", "sphinx"]
# Group first party and local folder imports together
no_lines_before = "LOCALFOLDER"

[tool.towncrier]
directory = "docs/changelog-fragments.d/"
filename = "CHANGELOG.md"
issue_format = "{{issue}}`{issue}`"
start_string = "<!-- towncrier release notes start -->\n\n"
template = "docs/changelog-fragments.d/.CHANGELOG-TEMPLATE.md.j2"
title_format = "## {version} - ({project_date})"
underlines = ["##", "###", "####", "#####"]

[[tool.towncrier.section]]
path = ""

[[tool.towncrier.type]]
directory = "bugfix"
name = "Bugfixes"
showcontent = true

[[tool.towncrier.type]]
directory = "feature"
name = "Features"
showcontent = true

[[tool.towncrier.type]]
directory = "deprecation"
name = "Deprecations (removal in next major release)"
showcontent = true

[[tool.towncrier.type]]
directory = "breaking"
name = "Backward incompatible changes"
showcontent = true

[[tool.towncrier.type]]
directory = "doc"
name = "Documentation"
showcontent = true

[[tool.towncrier.type]]
directory = "misc"
name = "Miscellaneous"
showcontent = true

[[tool.towncrier.type]]
directory = "internal"
name = "Contributor-facing changes"
showcontent = true
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ rtd =
sphinxext-rediraffe~=0.2
sphinxcontrib.mermaid~=0.6.3
sphinxext-opengraph~=0.4.2
sphinxcontrib-towncrier ~= 0.2.0a0
testing =
beautifulsoup4
coverage
Expand Down
Loading

0 comments on commit f7b4ca3

Please sign in to comment.