-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programmatic Creation of Roles and Teams #4303
Conversation
…available to all users
…nto feat/programmatic-teams-roles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrians5j I did a review, and posted some thoughts. We can talk this over via a call, if you'd like to discuss the suggestions.
packages/api-security/src/createSecurity/groupsTeamsPlugins/listGroupsFromPlugins.ts
Outdated
Show resolved
Hide resolved
packages/app-security-access-management/src/ui/views/Groups/GroupsForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrians5j I'm approving this now, because the feature works. I'll submit a separate PR with improvements to the code itself, so we can do it in parallel with the release preparations.
Changes
This PR enables users to create roles and teams programatically. For example:
With the above code in place, In the UI, users can see the following:
Additional Changes
1. Copy Permissions Button
This PR also adds the "Copy Permissions as JSON" button to all users. Previously this feature was hidden behind a feature flag:
With this feature, users will be able to define
permissions
property in thecreateSecurityRolePlugin
function much easier, because they'll just be able to select the desired permissions, copy them as JSON, and then paste them into their plugin.2. Added
createTestWcpLicense
Testing UtilityThe
createTestWcpLicense
utility was added in the@webiny/wcp
package, so that it can be used in Jest tests.3. Added Teams-related Tests
I've added basic tests for Teams functionality. They did not exist before. 🤯
How Has This Been Tested?
Manually / Jest.
Documentation
Changelog.