-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: advanced search filter builder for HCMS #3604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into leo/feat/advanced-search-filter
… into leo/feat/advanced-search-filter
… into leo/feat/advanced-search-filter
…be' into leo/feat/advanced-search-filter-be
# Conflicts: # packages/api-aco/package.json # packages/api-aco/src/createAcoContext.ts # packages/api-aco/src/types.ts # packages/form/src/Form.tsx
Pavel910
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are more places to rename from QueryBuilder
to Filter
, but we can do that later. This is looking great, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we introduce the new advanced search filter builder for HCMS.
The feature allows users to:
AND
/OR
)The following default fields are included:
status
createdOn
savedOn
The following model field types are included:
boolean
datetime
number
text
Bonus
The PR includes some improvements:
@webiny/form
package to improve the error validation.@webiny/ui/accordion
that allows to pass arbitrary elements to theAccordionItem
in addition to the existing buttonsVideo
CleanShot.2023-10-17.at.11.03.51.mp4
How Has This Been Tested?
Manually + Jest