-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lexical): add alt text on link node #3600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihajlovco
requested review from
adrians5j and
Pavel910
and removed request for
adrians5j
October 17, 2023 10:33
Pavel910
approved these changes
Oct 17, 2023
mihajlovco
changed the title
wip(lexical): add alt text on link node
feat(lexical): add alt text on link node
Oct 17, 2023
Pavel910
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow users to specify "alt text" to link. Technically in HTML, we add
alt
attribute to a link<a href="https://link.com" alt="link with alt text">
Changes
edit
andreview
have new components:LinkEditForm
andLinkReviewForm
Custom command and plugin for the link.
The default implementation of the Link payload doesn't support the
alt
attribute.LinkNodeAttributesPayload
payloadTOGGLE_LINK_NODE_COMMAND
to toggle the link creatingNew
alt
field for the LinkNode classalt
field by extending the original JSON object andLinkNodeAttributes
in the constructor.Improved UI
URL
andAlt text
, the user can save the form on theenter
key.How Has This Been Tested?
Manually
Test
Use case 1:
link-with-alt-text.mov
Use case 2:
working-with-ui.mov
Use case 3:
Convert the legacy link node to our custom link node that supports the
rel
attribute.Legacy link data:
Convert the link:
link-implementaion_legacy-link-single-word.mov
Converted legacy link data with test alt text 'a':