Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symfony Messenger to handle ItemImport messages #134

Merged
merged 24 commits into from
Aug 29, 2022
Merged

Use Symfony Messenger to handle ItemImport messages #134

merged 24 commits into from
Aug 29, 2022

Conversation

lruozzi9
Copy link
Member

Fixes #123

Changes proposed in this pull request:

  • Replace the custom consume command with Symfony Messenger

@webgriffe/wg-devs what do you think about this PR :shipit:?

@lruozzi9 lruozzi9 added the enhancement New feature or request label Jun 20, 2022
@lruozzi9 lruozzi9 added this to the v2.0.0 milestone Jun 20, 2022
@lruozzi9 lruozzi9 self-assigned this Jun 20, 2022
@lruozzi9
Copy link
Member Author

🛎️ 😆

@LucaGallinari
Copy link
Member

...it could be great to merge it before the next Christmas... 😆

LucaGallinari
LucaGallinari requested changes Jun 27, 2022
View reviewed changes
Copy link
Member

@LucaGallinari LucaGallinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I left just one comment

features/enqueuing_products.feature Show resolved Hide resolved
mmenozzi
mmenozzi requested changes Jul 25, 2022
View reviewed changes
features/managing_queue_items/browsing_queue_items.feature Show resolved Hide resolved
src/Command/EnqueueCommand.php Outdated Show resolved Hide resolved
src/Controller/ProductEnqueueController.php Outdated Show resolved Hide resolved
features/importing_product_associations_from_queue.feature Outdated Show resolved Hide resolved
@lruozzi9 lruozzi9 force-pushed the 123-use-symfony-messenger branch from 8866c2d to 3469d29 Compare August 1, 2022 09:13
@lruozzi9 lruozzi9 force-pushed the 123-use-symfony-messenger branch from 4daf2ce to 2a880fd Compare August 8, 2022 10:25
mmenozzi
mmenozzi approved these changes Aug 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lruozzi9 @mmenozzi
Update README.md
f10a37a 
Co-authored-by: Manuele Menozzi <[email protected]>
mmenozzi
mmenozzi reviewed Aug 8, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
LucaGallinari
LucaGallinari approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@LucaGallinari LucaGallinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some changes from "enqueue" to "import", for me it's all ok!

tests/Behat/Context/Cli/ImportCommandContext.php Outdated Show resolved Hide resolved
tests/Behat/Context/Cli/ImportCommandContext.php Outdated Show resolved Hide resolved
tests/Behat/Resources/suites.yml Outdated Show resolved Hide resolved
tests/Behat/Resources/suites.yml Show resolved Hide resolved
@lruozzi9 lruozzi9 merged commit b71d03a into master Aug 29, 2022
@lruozzi9 lruozzi9 deleted the 123-use-symfony-messenger branch August 29, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenozzi mmenozzi mmenozzi approved these changes

@LucaGallinari LucaGallinari LucaGallinari approved these changes

@fabianaromagnoli fabianaromagnoli Awaiting requested review from fabianaromagnoli

Assignees

@lruozzi9 lruozzi9

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Use Symfony Messenger
4 participants
@lruozzi9 @LucaGallinari @mmenozzi @fabianaromagnoli