Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AppLayout demos to use AppNav. #123

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

EHandtkeBasis
Copy link
Contributor

No description provided.

Copy link
Member

@hyyan hyyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In the AppLayoutMultipleHeadersView demo, the tabs appear to be misaligned or not functioning correctly.
  2. The AppLayoutStickyToolbarView seems to have no content ?!

Please carefully compare it with what has been published.

@EHandtkeBasis
Copy link
Contributor Author

I also checked stylewise wether or not the main toolbar being compact would fit better but decided to leave it as not compact.

.vscode/settings.json Outdated Show resolved Hide resolved
@hyyan hyyan self-requested a review December 11, 2024 11:16
Copy link
Member

@hyyan hyyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stick toolbars demo is still not working, and the toolbars still have spacing beneath them.

@hyyan
Copy link
Member

hyyan commented Dec 11, 2024

change "DWCJ Application" to become "Application" only

@hyyan
Copy link
Member

hyyan commented Dec 11, 2024

Remove the drawer’s header and footer from all demos.

@hyyan
Copy link
Member

hyyan commented Dec 11, 2024

Please format the code

@hyyan hyyan self-requested a review January 14, 2025 12:50
@hyyan
Copy link
Member

hyyan commented Jan 14, 2025

in applayout.css -> .layout__header remove the padding

@hyyan
Copy link
Member

hyyan commented Jan 14, 2025

remove webforj logo from all demos.

Copy link
Member

@hyyan hyyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EHandtkeBasis, could you please take a look at the demos that have already been published? The new rewrite version seems to be off and doesn’t match the published ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants