SPARK-532493 webrtc core should expose separate events for ice and connection state #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2024 17:19
…e connection state
…e connection state
…for-ice-and-connection-state' of https://github.com/webex/webrtc-core into spark-532493-webrtc-core-should-expose-separate-events-for-ice-and-connection-state
k-wasniowski
requested review from
szotrabh,
bbaldino,
marcin-bazyl and
brycetham
brycetham
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Agreed with @marcin-bazyl's comments. Also left a comment about naming.
k-wasniowski
force-pushed
the
spark-532493-webrtc-core-should-expose-separate-events-for-ice-and-connection-state
branch
from
eefe004
to
3513785
Compare
marcin-bazyl
previously approved these changes
Jun 11, 2024
brycetham
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Looks good, left a minor comment. As I discussed with you offline, since this is technically a breaking change, I would check with the SDK team to make sure they are ok with it, as this might affect some SDK customers. Likely they will need to document this somewhere, so I might wait until you get the ok before merging.
k-wasniowski
dismissed stale reviews from brycetham and marcin-bazyl
via
48e0bea
szotrabh
approved these changes
Jun 12, 2024
k-wasniowski
deleted the
spark-532493-webrtc-core-should-expose-separate-events-for-ice-and-connection-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR divide evaluating of overall connection state to two separated events.
We have decided that it's useful to have access to both events IceConnectionState and ConnectionState separately.
It's required for JS-SDK to have access directly to the reason of media join failure.