feat: separate API for enabled and muted states #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
reviewed
Feb 29, 2024
src/media/stream.ts
Outdated
| @@ -5,8 +5,15 @@ export enum StreamEventNames { | |||
| Ended = 'stream-ended', | |||
| } | |||
|
|
|||
| export enum MuteStateChangeReason { | |||
There was a problem hiding this comment.
A bit of a nitpick, but I wonder if we should re-phrase this as "MuteStateChangeSource" and the values be more "plain nouns" (User, Browser).
brycetham
changed the title
| /** | ||
| * @inheritdoc | ||
| */ | ||
| protected addTrackHandlers(track: MediaStreamTrack): void { |
There was a problem hiding this comment.
what happens when RemoteStream.replaceTrack() is called and the previous track was muted, but the new one isn't. Should we emit the MediaStateChange event?
There was a problem hiding this comment.
There's no "mute" for remote (something we're trying to correct with new vocabulary), but I think this point still stands in that the media states could differ...maybe we need to compare the old and new states at replacement time.
There was a problem hiding this comment.
That's a good point. Yeah, I think we should.
bbaldino
previously approved these changes
Mar 11, 2024
bbaldino
approved these changes
Mar 11, 2024
marcin-bazyl
approved these changes
Mar 12, 2024
bbaldino
pushed a commit
that referenced
this pull request
Mar 12, 2024
# [2.6.0](v2.5.0...v2.6.0) (2024-03-12) ### Features * separate API for enabled and muted states ([#72](#72)) ([f4ce41d](f4ce41d))
marcin-bazyl
added a commit
that referenced
this pull request
Mar 20, 2024
This reverts commit f4ce41d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mute events and getters to make it clear whether the user muted the stream or the system muted the stream as part of SPARK-493485. The main changes are:
Stream:MuteStateChange. This will be replaced with new events inLocalStream/RemoteStream.LocalStream:UserMuteStateChange, emits a boolean with the new user mute state.SystemMuteStateChange, emits a boolean with the new system mute state.userMuted/systemMutedmutedwill be inLocalStreamonly, gets the overall mute state (taking into consideration bothuserMutedandsystemMuted)RemoteStream:MediaStateChange, emits either "started" or "stopped".mutedand replace with gettermediaState, returns "started" or "stopped".