Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(internal-plugin-usersub): add usersub plugin to allow the publis… #3936
base: next
Are you sure you want to change the base?
feat(internal-plugin-usersub): add usersub plugin to allow the publis… #3936
Changes from all commits
699457b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle empty
deviceId
before sending the requestThe
deviceId
extracted by_extractIdFromUrl
could be an empty string if the device URL does not match the expected format. This may cause issues in the JSON payload sent to the server. Consider adding a check to handle the case whendeviceId
is empty or invalid.Apply this diff to validate
deviceId
before sending the request:Then, update
jsonData
to use thedeviceId
variable:📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deviceId can be empty - so not rejecting it in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmulcair1981, understood. Thank you for the clarification.
(_/)
(•_•)
(>🌸<)
✏️ Learnings added