Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-meetings): resolved guest issue forbidden error #3861

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

Parimala032
Copy link
Collaborator

@Parimala032 Parimala032 commented Sep 26, 2024

COMPLETES #< SPARK-561608 >

This pull request addresses

This PR is used to address the 403 Forbidden issues that the user had seen in the meetings widgets sample app. When a user clicks on the register button in the logs it shows a 403 forbidden error but the user can join the meeting which means these are unnecessary logs that should be avoided. So, we are fixing this issue first in the kitchen sink app so that the meetings widgets get fixed where the following changes are made to work fine so that users don't get the unnecessary logs again.

by making the following changes

Whenever a user joins a meeting as a user/guest then we will ignore the 403 forbidden error (unnecessary logs) but this does not happen with the verified user. so for that, I used the people API to fetch the user details in this I found that the user is a type of "appuser" so based on this I modified the function "fetchUserPreferredWebexSite" whenever the Guest is joining into the meeting we won't call the "meetingprefernces API" and this will ignore the unnecessary logs as well as in vice versa, it will call the "meetingprefernces API" whenever verified user is trying to join the meeting.

master.branch.403.issue.recording.mp4

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

Tested by using the guest token ------> works fine as expected (shouldn't log the unnecessary logs (403))
Tested by using the verified Access token ---------> works fine as expected
"Refer to the screen recording"

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@Parimala032 Parimala032 requested review from a team as code owners September 26, 2024 10:33
@Parimala032 Parimala032 added the validated If the pull request is validated for automation. label Sep 26, 2024
@Parimala032 Parimala032 marked this pull request as draft September 26, 2024 10:34
@Parimala032 Parimala032 changed the title fix: resolved guest issue forbidden error fix(plugin-meetings): resolved guest issue forbidden error Sep 26, 2024
@pagour98
Copy link

@Parimala032
In the recording, I see there are some hidden messages in the console can you let me know what are they?

@Parimala032
Copy link
Collaborator Author

@Parimala032 In the recording, I see there are some hidden messages in the console can you let me know what are they?

@pagour98 hidden messages are in the console are third party issues parv and this hidden messages you can able to see in the github.io (meetings sample app)

@Parimala032 Parimala032 marked this pull request as ready for review October 2, 2024 15:22
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we get a review from WWC folks? Please check the comments as well

@Parimala032
Copy link
Collaborator Author

Parimala032 commented Oct 3, 2024

Did we get a review from WWC folks? Please check the comments as well

No @mkesavan13 for the master branch it's not needed

@pagour98
Copy link

pagour98 commented Oct 3, 2024

@Parimala032 Workflow: github_checks is failing, pls check...
Yes @pagour98 it's failing because it's a master branch we have the tooling difference in the master branch but it passes locally

@sreenara
Copy link
Contributor

sreenara commented Oct 4, 2024

@Parimala032 Workflow: github_checks is failing, pls check... Yes @pagour98 it's failing because it's a master branch we have the tooling difference in the master branch but it passes locally

@pagour98 the workflow github_checks should actually no longer be there. We just haven't removed them. These are checks happening on CircleCI, which we no longer use for the pipeline. Actions are the only steps we need to check.

@sreenara sreenara merged commit 5015271 into webex:master Oct 4, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants