Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cart): add backward compatibility voicea data format #3635

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

mickelr
Copy link
Contributor

@mickelr mickelr commented Jun 10, 2024

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

We have two major customers (Davra, Instant Connect) who use the Closed Captions through the new V3 SDK already and are actively testing and migrating to the V3 SDK. They rely on these events and the payload format.

by making the following changes

add backward compatibility voicea transcript data format

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@mickelr mickelr requested a review from a team as a code owner June 10, 2024 03:47
@mickelr mickelr added the validated If the pull request is validated for automation. label Jun 10, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3635.d3m3l2kee0btzx.amplifyapp.com

Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mkesavan13 mkesavan13 requested a review from a team as a code owner June 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants