-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webex-core): adding support for a custom proxy #3624
base: next
Are you sure you want to change the base?
Conversation
If this PR is accepted, it is recommended that the proxy documentation on this wiki page be updated to include both the websocket proxy setup as well as this new http proxy setup. |
@Tiuipuv, the SDK team will review this PR. Please stand-by. |
Hi @Tiuipuv Sorry for the delay. I am looking into this PR. While I do that, could you please get the latest changes from the next branch updated to your branch? |
Also, I see Integration test failures. Please look into it. @Tiuipuv |
7befb70
to
76e6869
Compare
PR is updated to latest next branch. I will investigate the integration failure next week. I do not have access to the 4 environment variables from my organization: WEBEX_CLIENT_ID=""
WEBEX_CLIENT_SECRET=""
WEBEX_APPID_ORGID=""
WEBEX_APPID_SECRET="" is there any shared test environment I can use? |
76e6869
to
1913f20
Compare
1913f20
to
112c99a
Compare
There isn't any shared test environment unfortunately. @mkesavan13 we will need to take a look at this and see if this is an existing failure. |
Thanks for the info @sreenara. Let me know if there is anything I can do to help with this Pull Request @mkesavan13! |
This pull request addresses
Adding support for an app to set a custom proxy on all requests. The app can control this by setting the proxy configuration during init. e.g.
By allowing for custom
proxy
it'll be easier for organizations utilizing a proxy to be able to connect to the webex sdk via NodeJS.by making the following changes
These changes include:
webex-core
, calledProxyInterceptor
webex-core
, to run against everyonRequest
ProxyInterceptor
Change Type
The following scenarios where tested
I certified that
Make sure to have followed the contributing guidelines before submitting.