fix(new-metrics): add TypeError #3527
Open
+78
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
nataliadelmar
added
the
validated
torgeadelin
reviewed
Apr 12, 2024
| * Any service can return a TypeError, which tells little about the service it came from | ||
| * Documentation can be found here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypeError/TypeError | ||
| * | ||
| * @param errorCode |
There was a problem hiding this comment.
this is not really an error code
| @@ -127,6 +126,7 @@ export const ERROR_DESCRIPTIONS = { | |||
| ICE_FAILED_WITH_TURN_TLS: 'ICEFailedWithTURN_TLS', | |||
| SDP_OFFER_CREATION_ERROR: 'SdpOfferCreationError', | |||
| SDP_OFFER_CREATION_ERROR_MISSING_CODEC: 'SdpOfferCreationErrorMissingCodec', | |||
| TYPE_ERROR: 'TypeError', | |||
There was a problem hiding this comment.
why did you add it under SDP section? Is TypeError not a generic thing?
|
We are no longer accepting PRs on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses
Right now, if a client metric event contains a TypeError error, it gets classified as 'BrowserMediaError' because TypeError is one of the possible error that can result from MediaDevices: getUserMedia() method (https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia#aborterror:~:text=individual%20user%20agent.-,TypeError,-Thrown%20if%20the)
by making the following changes
That assumption is wrong, as any service can return a TypeError and, unfortunately, we do not have a way of identifying the service this error comes from. So this PR classifies it as a TypeError of category 'other'.
Change Type
The following scenarios where tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.