Skip to content

Commit

Permalink
fix(plugin-meetings): remove StatsAnalyzer in sdk (#3769)
Browse files Browse the repository at this point in the history
Co-authored-by: Anna Tsukanova <[email protected]>
  • Loading branch information
antsukanova and Anna Tsukanova authored Aug 28, 2024
1 parent da7fd81 commit 7a7e5f9
Show file tree
Hide file tree
Showing 22 changed files with 552 additions and 4,821 deletions.
2 changes: 1 addition & 1 deletion packages/@webex/media-helpers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"deploy:npm": "yarn npm publish"
},
"dependencies": {
"@webex/internal-media-core": "2.8.0",
"@webex/internal-media-core": "2.9.0",
"@webex/ts-events": "^1.1.0",
"@webex/web-media-effects": "2.18.0"
},
Expand Down
8 changes: 4 additions & 4 deletions packages/@webex/media-helpers/test/unit/spec/webrtc-core.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
createDisplayStream,
createDisplayStreamWithAudio,
} from '@webex/media-helpers';
import * as wcmestreams from '@webex/internal-media-core';
import * as InternalMediaCoreModule from '@webex/internal-media-core';

describe('media-helpers', () => {
describe('webrtc-core', () => {
Expand Down Expand Up @@ -120,7 +120,7 @@ describe('media-helpers', () => {
it('checks creating tracks', async () => {
const constraints = {deviceId: 'abc'};

const spy = sinon.stub(wcmestreams, spyFn).returns('something');
const spy = sinon.stub(InternalMediaCoreModule, spyFn).returns('something');
const result = await createFn(constraints);

assert.equal(result, 'something');
Expand All @@ -132,7 +132,7 @@ describe('media-helpers', () => {

describe('createDisplayStream', () => {
it('checks createDisplayStream', async () => {
const spy = sinon.stub(wcmestreams, 'createDisplayStream').returns('something');
const spy = sinon.stub(InternalMediaCoreModule, 'createDisplayStream').returns('something');
const result = await createDisplayStream();
assert.equal(result, 'something');
assert.calledOnceWithExactly(spy, LocalDisplayStream);
Expand All @@ -141,7 +141,7 @@ describe('media-helpers', () => {

describe('createDisplayStreamWithAudio', () => {
it('checks createDisplayStreamWithAudio', async () => {
const spy = sinon.stub(wcmestreams, 'createDisplayStreamWithAudio').returns('something');
const spy = sinon.stub(InternalMediaCoreModule, 'createDisplayStreamWithAudio').returns('something');
const result = await createDisplayStreamWithAudio();
assert.equal(result, 'something');
assert.calledOnceWithExactly(spy, LocalDisplayStream, LocalSystemAudioStream);
Expand Down
2 changes: 1 addition & 1 deletion packages/@webex/plugin-meetings/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
},
"dependencies": {
"@webex/common": "workspace:*",
"@webex/internal-media-core": "2.8.0",
"@webex/internal-media-core": "2.9.0",
"@webex/internal-plugin-conversation": "workspace:*",
"@webex/internal-plugin-device": "workspace:*",
"@webex/internal-plugin-llm": "workspace:*",
Expand Down
17 changes: 0 additions & 17 deletions packages/@webex/plugin-meetings/src/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,23 +250,6 @@ export const ASSIGN_ROLES_ERROR_CODES = {
ReclaimHostIsHostAlreadyErrorCode: 2409150,
};

export const DEFAULT_GET_STATS_FILTER = {
types: [
'track',
'transport',
'candidate-pair',
'outbound-rtp',
'outboundrtp',
'inbound-rtp',
'inboundrtp',
'remote-inbound-rtp',
'remote-outbound-rtp',
'remote-candidate',
'local-candidate',
'media-source',
],
};

export const RECORDING_STATE = {
RECORDING: 'recording',
IDLE: 'idle',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Defer} from '@webex/common';
import {ConnectionState, Event} from '@webex/internal-media-core';
import {ConnectionState, MediaConnectionEventNames} from '@webex/internal-media-core';
import LoggerProxy from '../common/logs/logger-proxy';
import {ICE_AND_DTLS_CONNECTION_TIMEOUT} from '../constants';

Expand Down Expand Up @@ -69,15 +69,15 @@ export default class MediaConnectionAwaiter {
*/
private clearCallbacks(): void {
this.webrtcMediaConnection.off(
Event.ICE_GATHERING_STATE_CHANGED,
MediaConnectionEventNames.ICE_GATHERING_STATE_CHANGED,
this.iceGatheringStateCallback
);
this.webrtcMediaConnection.off(
Event.PEER_CONNECTION_STATE_CHANGED,
MediaConnectionEventNames.PEER_CONNECTION_STATE_CHANGED,
this.peerConnectionStateCallback
);
this.webrtcMediaConnection.off(
Event.ICE_CONNECTION_STATE_CHANGED,
MediaConnectionEventNames.ICE_CONNECTION_STATE_CHANGED,
this.iceConnectionStateCallback
);
}
Expand Down Expand Up @@ -228,17 +228,17 @@ export default class MediaConnectionAwaiter {
}

this.webrtcMediaConnection.on(
Event.PEER_CONNECTION_STATE_CHANGED,
MediaConnectionEventNames.PEER_CONNECTION_STATE_CHANGED,
this.peerConnectionStateCallback
);

this.webrtcMediaConnection.on(
Event.ICE_CONNECTION_STATE_CHANGED,
MediaConnectionEventNames.ICE_CONNECTION_STATE_CHANGED,
this.iceConnectionStateCallback
);

this.webrtcMediaConnection.on(
Event.ICE_GATHERING_STATE_CHANGED,
MediaConnectionEventNames.ICE_GATHERING_STATE_CHANGED,
this.iceGatheringStateCallback
);

Expand Down
266 changes: 0 additions & 266 deletions packages/@webex/plugin-meetings/src/mediaQualityMetrics/config.ts

This file was deleted.

Loading

0 comments on commit 7a7e5f9

Please sign in to comment.