feat: get screen and window info #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvujic
commented
Jul 5, 2024
| * @returns The width of the screen in pixels, or undefined if not available. | ||
| */ | ||
| static getScreenWidth(): number | undefined { | ||
| return window.screen.width; |
There was a problem hiding this comment.
window.screen.width and screen.width will produce the same result. Both properties access the width property of the global screen object.
though, when using only screen.width we get the following eslint problem // eslint-disable-next-line no-restricted-globals
edvujic
commented
Jul 5, 2024
| it('returns the correct window width and height when accessed', () => { | ||
| expect.hasAssertions(); | ||
|
|
||
| Object.defineProperty(window, 'innerWidth', { |
There was a problem hiding this comment.
innerWidth and innerHeight do not have a get property, so they couldn't be spied on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of WEBEX-379503
Add screen and window size reporting for MQRs
Description:
Used for MQRs report_intervalMetadata_screenResolution and report_intervalMetadata_appWindow(Height/Width/Size).
Screen size can be retrieved from the Screen API: https://developer.mozilla.org/en-US/docs/Web/API/Screen.
Window size can be retrieved from the Window API: https://developer.mozilla.org/en-US/docs/Web/API/Window.