Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HEX encoding for very large numbers - issue #268 #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaiesh
Copy link

@kaiesh kaiesh commented Aug 14, 2022

Very large non-negative numbers are encoded to hex strings in excess of 64 chars - this is due to Two's Complement representation being set to true on these non-negative numbers.

This minor edit ensures that Two's Complement representation on hex conversion is only applied when the number is actually negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant