feat: add get/request/revoke permissions methods #9
Conversation
krzysu
force-pushed
the
feat-examples
branch
3 times, most recently
from
242de10
to
02b206e
Compare
krzysu
changed the title
krzysu
requested review from
danforbes,
avkos,
Muhammad-Altabba,
luu-alex and
jdevcs
| * @returns a Promise that resolves if the request is successful | ||
| * @param param - Details of the chain to switch to and possibly add. | ||
| * @returns A Promise that resolves if the request is successful. | ||
| * @experimental |
There was a problem hiding this comment.
Since other libraries don’t implement this method and wallets appear not to support them, I’ve moved it to experimental. I’ll eventually remove it if I don’t find a wallet that supports it.
| * @returns a Promise that resolves to a list of owned assets | ||
| * @param param - Details of the request for owned assets. | ||
| * @returns A Promise that resolves to a list of owned assets. | ||
| * @experimental |
There was a problem hiding this comment.
Since other libraries don’t implement this method and wallets appear not to support them, I’ve moved it to experimental. I’ll eventually remove it if I don’t find a wallet that supports it.
.vscode/settings.json
Outdated
| { | ||
| "eslint.workingDirectories": [ | ||
| "packages/example-react-app", | ||
| "packages/web3-plugin-wallet-rpc" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Should this file be checked-in?
There was a problem hiding this comment.
ok, removed for now, let's wait if others will have similar problems
| @@ -3,15 +3,16 @@ | |||
| This Web3.js plugin adds support for the following wallet-related RPC methods: | |||
|
|
|||
| - [wallet_addEthereumChain (EIP-3085)](https://eips.ethereum.org/EIPS/eip-3085) | |||
There was a problem hiding this comment.
Since you link the EIPs in the descriptions below, I think these links should point to the anchors for the respective method descriptions.
There was a problem hiding this comment.
done per function in the examples below, here is the link to the full EIP
No description provided.