chore: new eslint for react app #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysu
requested review from
danforbes,
avkos,
Muhammad-Altabba,
luu-alex and
jdevcs
krzysu
force-pushed
the
feat-examples-2
branch
from
60019dd
to
0764d30
Compare
danforbes
approved these changes
Oct 29, 2024
krzysu
force-pushed
the
feat-examples-2
branch
from
0764d30
to
5fb435e
Compare
krzysu
force-pushed
the
feat-examples-2
branch
from
5fb435e
to
0a2e56b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default react-scripts linter is quite lenient, so I’d like to adopt a stricter setup to enhance code quality. I found that ChainSafe’s ESLint configuration includes settings for React apps, so I’m integrating it here. However, it conflicts with some Prettier settings, which I’ve temporarily ignored in certain places. What do you think?