-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Minimal Angular Template #3
Conversation
"scripts": { | ||
"ng": "ng", | ||
"start": "ng serve", | ||
"build": "ng build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this template what do you think for adding build
(and later test
) in CLI tool's github CI, so with every PR we will be able to detect if any thing is breaking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea! I will add that 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for using this template with cli tool could you modify create-web3js-dapp/src
/index.js in same PR? so its usable with
npx create-web3js-dapp angular
,npx create-web3js-dapp angular min
and- also with interactive cli tool screen. thanks
Can we create a separate Issue for this under the CLI tool Epic we talked about? I'm trying to keep this PR scoped to web3/web3.js#7199 and web3/web3.js#7213. |
@jdevcs I've created a draft PR for the above. It's downstream from the branch for this PR so I will move it out of draft state once this PR has been merged. |
plus also create issue for this and add in sprint (cc: @mconnelly8 ) thanks |
Created #6 |
Closes web3/web3.js#7199
Closes web3/web3.js#7213