Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimal Angular Template #3

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Add Minimal Angular Template #3

merged 4 commits into from
Sep 23, 2024

Conversation

danforbes
Copy link
Collaborator

"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this template what do you think for adding build (and later test ) in CLI tool's github CI, so with every PR we will be able to detect if any thing is breaking.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I will add that 💯

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also for using this template with cli tool could you modify create-web3js-dapp/src
/index.js in same PR? so its usable with

  • npx create-web3js-dapp angular ,
  • npx create-web3js-dapp angular min and
  • also with interactive cli tool screen. thanks

@danforbes
Copy link
Collaborator Author

also for using this template with cli tool could you modify create-web3js-dapp/src /index.js in same PR? so its usable with

  • npx create-web3js-dapp angular ,
  • npx create-web3js-dapp angular min and
  • also with interactive cli tool screen. thanks

Can we create a separate Issue for this under the CLI tool Epic we talked about? I'm trying to keep this PR scoped to web3/web3.js#7199 and web3/web3.js#7213.

@danforbes
Copy link
Collaborator Author

also for using this template with cli tool could you modify create-web3js-dapp/src /index.js in same PR? so its usable with

  • npx create-web3js-dapp angular ,
  • npx create-web3js-dapp angular min and
  • also with interactive cli tool screen. thanks

@jdevcs I've created a draft PR for the above. It's downstream from the branch for this PR so I will move it out of draft state once this PR has been merged.

@jdevcs
Copy link
Contributor

jdevcs commented Sep 20, 2024

also for using this template with cli tool could you modify create-web3js-dapp/src /index.js in same PR? so its usable with

  • npx create-web3js-dapp angular ,
  • npx create-web3js-dapp angular min and
  • also with interactive cli tool screen. thanks

@jdevcs I've created a draft PR for the above. It's downstream from the branch for this PR so I will move it out of draft state once this PR has been merged.

plus also create issue for this and add in sprint (cc: @mconnelly8 ) thanks

@danforbes danforbes mentioned this pull request Sep 20, 2024
@danforbes
Copy link
Collaborator Author

plus also create issue for this and add in sprint (cc: @mconnelly8 ) thanks

Created #6

@danforbes danforbes merged commit db5ed3f into main Sep 23, 2024
1 check passed
@danforbes danforbes deleted the feat/templates/angular-min branch September 23, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Angular template documentation Create Sample Project for Angular + Web3.js
2 participants