Agavgavi agavgavi/dashboard (without htmx) #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly display input even when value === False.
…s to look better on form.
agavgavi
reviewed
Sep 6, 2021
apps/_dashboard/static/js/dbadmin.js
Outdated
Comment on lines
1
to
6
| var app = Q.app(); | ||
| var params = new URLSearchParams(window.location.search); | ||
| app.data.loading = 0; | ||
| app.data.app = params.get('app'); | ||
| app.data.dbname = params.get('dbname'); | ||
| app.data.tablename = params.get('tablename'); | ||
| app.data.url = '/_dashboard/rest/{app}/{dbname}/{tablename}'.format(app.data); | ||
| app.data.filter = params.get('filter') || ''; | ||
| app.data.order = params.get('order') || ''; | ||
| app.start(); |
There was a problem hiding this comment.
I believe this whole file can be removed now that it isn't included anymore.
agavgavi
reviewed
Sep 6, 2021
apps/_dashboard/__init__.py
Outdated
Comment on lines
285
to
295
| grid.formatters_by_type["date"] = ( | ||
| lambda value: value.strftime("%m/%d/%Y") if value else "" | ||
| ) | ||
|
|
||
| grid.formatters_by_type["time"] = ( | ||
| lambda value: value.strftime("%H:%M:%S") if value else "" | ||
| ) | ||
|
|
||
| grid.formatters_by_type["datetime"] = ( | ||
| lambda value: value.isoformat() if value else "" | ||
| ) |
There was a problem hiding this comment.
These formatters were included to replace the javascript timezone based formatting that already exists in the Grid due to HTMX's issues with injecting Javascript. If we are going back to just normal HTML then I do believe that these are unecessary but I haven't tried it.
|
I agree.
Also the css is slightly broken. Would you be able to look into both? If
not I can do it later.
…On Sun, Sep 5, 2021 at 10:05 PM Andrew Gavgavian ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/_dashboard/static/js/dbadmin.js
<#631 (comment)>:
> var app = Q.app();
var params = new URLSearchParams(window.location.search);
-app.data.loading = 0;
app.data.app = params.get('app');
app.data.dbname = params.get('dbname');
app.data.tablename = params.get('tablename');
-app.data.url = '/_dashboard/rest/{app}/{dbname}/{tablename}'.format(app.data);
-app.data.filter = params.get('filter') || '';
-app.data.order = params.get('order') || '';
app.start();
I believe this whole file can be removed now that it isn't included
anymore.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#631 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLZT43T4ZZJLXYY7B6XRTUARDZ5ANCNFSM5DPUCVRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
the lighter the better. I have not tested date/time/datetime
…On Sun, Sep 5, 2021 at 10:07 PM Andrew Gavgavian ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/_dashboard/__init__.py
<#631 (comment)>:
> + grid.formatters_by_type["date"] = (
+ lambda value: value.strftime("%m/%d/%Y") if value else ""
+ )
+
+ grid.formatters_by_type["time"] = (
+ lambda value: value.strftime("%H:%M:%S") if value else ""
+ )
+
+ grid.formatters_by_type["datetime"] = (
+ lambda value: value.isoformat() if value else ""
+ )
These formatters were included to replace the javascript timezone based
formatting that already exists in the Grid due to HTMX's issues with
injecting Javascript. If we are going back to just normal HTML then I do
believe that these are unecessary but I haven't tried it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#631 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLZTY6VXTUS5HL32NTFQDUAREBRANCNFSM5DPUCVRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I am busy tonight sadly with family and unable to do so, my apologies. |
|
No apology needed. same boat here. Maybe I will find some time later. :-)
…On Sun, Sep 5, 2021 at 10:09 PM Andrew Gavgavian ***@***.***> wrote:
I am busy tonight sadly with family and unable to do so, my apologies.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#631 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLZT7QHZGVSHPIX37R2G3UAREKLANCNFSM5DPUCVRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.