Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add auto-deployment via Changesets #74

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Aug 26, 2023

See @chaance's remix-run#9 & @mcansh's remix-run#16


#101 needs to be merged first

@Gozala
Copy link
Contributor

Gozala commented Aug 28, 2023

Hy @MichaelDeBoey I don't have anything against Changesets, but I also have no experience using it. I'm hesitant to switch from release-please to Changesets unless there is a compiling reason for it as adopting it would take up already scarce time I have available for this project.

That said if you do have a compelling case please point those out so they could be considered.

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented Aug 29, 2023

@Gozala We use changesets in the Remix repos, so both @jacob-ebey & I are used to it

One of the main benefits of changesets is that you can create a whole custom explanation for your release notes as part of your PR, which is something that's not possible with release-please
Another benefit is that it automatically updates the version numbers of nested dependencies (so if blob updates, the version number of blob will be changed in all other package.jsons)

This PR also adds some nice things like manypkg to help with monorepo best practices

@MichaelDeBoey
Copy link
Contributor Author

@Gozala Is there anything else you want me to do before we can merge this one?

@jacob-ebey
Copy link
Contributor

Release please is the shit and if I had my way Remix would release with it. Don't let our release process influence how you manage this project.

@MichaelDeBoey MichaelDeBoey force-pushed the deploy branch 4 times, most recently from 4b42294 to d2bd752 Compare April 7, 2025 09:24
@MichaelDeBoey MichaelDeBoey requested review from a team and Copilot April 7, 2025 10:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (7)
  • .changeset/config.json: Language not supported
  • package.json: Language not supported
  • packages/blob/package.json: Language not supported
  • packages/fetch/package.json: Language not supported
  • packages/file/package.json: Language not supported
  • packages/form-data/package.json: Language not supported
  • packages/stream/package.json: Language not supported

@MichaelDeBoey MichaelDeBoey marked this pull request as draft April 7, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants