Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fetch): add support for HTTP2 pseudo headers #104

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(fetch): add support for HTTP2 pseudo headers #104

wants to merge 3 commits into from

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Apr 7, 2025 •
edited
Loading

See @pcattori's remix-run#55

#101 needs to be merged first

MichaelDeBoey and others added 3 commits April 7, 2025 13:04
@MichaelDeBoey
fix(CI): stop testing on Node 14
e55e8cf
@pcattori @MichaelDeBoey
Add support for HTTP2 pseudo headers (remix-run#55)
54a5565 
* fix(headers): do not depend on `http` for header name validation

Node internally uses undici instead anyway

* fix(headers): support HTTP2 pseudo-headers

which begin with `:` e.g. `:authority`, `:method`, etc.

* test(headers): check that pseudo-headers are allowed
@MichaelDeBoey
chore: fix changeset
71dfe89
@MichaelDeBoey MichaelDeBoey requested review from Gozala, a team and Copilot April 7, 2025 11:54
Copilot
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

@MichaelDeBoey MichaelDeBoey marked this pull request as draft April 7, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Gozala Gozala Awaiting requested review from Gozala

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @pcattori