Add test for innerHTML, innerText, textContent, text and src IDL prop… #50022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erties These properties allow to change a script text or URL and need special attention. Existing tests for them are scattered over multiple files and check many other things. This new test focuses on checking whether setting these properties to a plain string would be blocked by a default policy, and what trusted type name and sink names would be passed to the corresponding create callback. We try setting the properties on HTMLDivElement, HTMLScriptElement or SVGScriptElement when they exist.
|
cc @lukewarlow I'm not quite sure what the SVG behavior would be, given that's currently not defined in the spec IIUC. |
|
OK, I have added what the spec currently for SVG innerText and textContent too, we can always change that if the spec changes. The tests pass in all browsers. |
fred-wang
deleted the
blocking-string-assignment-to-text-and-urls-properties
branch
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 14, 2025
#50022) These properties allow to change a script text or URL and need special attention. Existing tests for them are scattered over multiple files and check many other things. This new test focuses on checking whether setting these properties to a plain string would be blocked by a default policy, and what trusted type name and sink names would be passed to the corresponding create callback. We try setting the properties on HTMLDivElement, HTMLScriptElement or SVGScriptElement when they exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erties
These properties allow to change a script text or URL and need special attention. Existing tests for them are scattered over multiple files and check many other things. This new test focuses on checking whether setting these properties to a plain string would be blocked by a default policy, and what trusted type name and sink names would be passed to the corresponding create callback. We try setting the properties on HTMLDivElement, HTMLScriptElement or SVGScriptElement when they exist.