Mark tests failed with 500 disconnected error as crash #48059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
WeizhongX
requested review from
jonathan-j-lee and
jgraham
and removed request for
jgraham,
foolip and
DanielRyanSmith
|
The change is tested in Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5840083 |
jonathan-j-lee
approved these changes
Sep 9, 2024
In a multiple processes architecture, when the renderer processes crashed, the liveness check won't necessary fail as the browser process is still running. One common error we see in Chromium is that webdriver will report 500 disconnected, with an error message "Unable to receive message from renderer". Previously the test result is Internal Error instead of Crash. Bug: 362506646
WeizhongX
force-pushed
the
500-disconnected-as-crash
branch
from
bbf0e36 to
960ec96
Compare
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
jonathan-j-lee
approved these changes
Sep 10, 2024
|
@jcscottiii can you help admin merge this? The failure on infrastructure/ tests should not be caused by my change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multiple processes architecture, when the renderer processes crashed, the liveness check won't necessary fail as the browser process is still running. One common error we see in Chromium is that webdriver will report 500 disconnected, with an error message "Unable to receive message from renderer". Previously the test result is Internal Error instead of Crash.
Bug: 362506646