wpt: check for wpt-prefs.json in "./servo" sub-directory #47805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current working directory when running on WPT runners is not the folder with the servo binary, but a parent folder into which the servo nightly tar is extracted. This means the binary is `$PWD/servo/servo` and resources directory in in `$PWD/servo/resources`, so the current hardcoded relative path `resources/wpt-prefs.json` will not work on WPT runners. This is causing crashes in WPT runner: https://github.com/web-platform-tests/wpt/runs/29284407168 https://community-tc.services.mozilla.com/tasks/J7MqNwJGQRSkIWlvB5ktPQ/runs/0/logs/live/public/logs/live.log Signed-off-by: Mukilan Thiyagarajan <[email protected]>
3 tasks
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current working directory when running on WPT runners is not the
folder with the servo binary, but a parent folder into which the servo
nightly tar is extracted. This means the binary is
$PWD/servo/servoand resources directory in in
$PWD/servo/resources, so the currenthardcoded relative path
resources/wpt-prefs.jsonwill not work on WPTrunners.
This is causing crashes in WPT runner:
https://github.com/web-platform-tests/wpt/runs/29284407168
https://community-tc.services.mozilla.com/tasks/J7MqNwJGQRSkIWlvB5ktPQ/runs/0/logs/live/public/logs/live.log#L696
This is a quick fix, so there might be a better way to handle this.
Signed-off-by: Mukilan Thiyagarajan [email protected]
Reviewed in servo/servo#33202