PointerEvent WPT for compat mouse events: fix timeout in FF and Safari #24954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 11, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2348530
branch
2 times, most recently
from
1c6f439 to
9f7e656
Compare
Different browsers fire different number of events for this test. Stop the test when the done button is clicked instead of when a certain number of events are fired. There are significant differences in how browsers fire pointer events and compatible mouse events when an element is removed from the DOM. There is a discussion here: w3c/pointerevents#285 about the order of pointerenter events and compatible mouseenter events when an element is removed from the DOM. Once the discussion is finalized and there is consensus this test might have to be adjusted. Change-Id: I5202eb7a1fcc557985279a978596c9446105f417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348530 Commit-Queue: Liviu Tinta <[email protected]> Reviewed-by: Mustaq Ahmed <[email protected]> Cr-Commit-Position: refs/heads/master@{#796943}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2348530
branch
from
9f7e656 to
796e339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different browsers fire different number of events for this test. Stop
the test when the done button is clicked instead of when a certain
number of events are fired.
There are significant differences in how browsers fire pointer events
and compatible mouse events when an element is removed from the DOM.
There is a discussion here: w3c/pointerevents#285
about the order of pointerenter events and compatible mouseenter events when an
element is removed from the DOM. Once the discussion is finalized and
there is consensus this test might have to be adjusted.
Change-Id: I5202eb7a1fcc557985279a978596c9446105f417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348530
Commit-Queue: Liviu Tinta <[email protected]>
Reviewed-by: Mustaq Ahmed <[email protected]>
Cr-Commit-Position: refs/heads/master@{#796943}