Skip to content

Commit

Permalink
Make the Safari workflows not be invalid workflow files
Browse files Browse the repository at this point in the history
We can't put a YAML comment within a string, it needs to be actual
YAML syntax.
  • Loading branch information
gsnedders committed Sep 12, 2024
1 parent 3a73b22 commit 9326ce5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/safari_stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ jobs:
safari-stable-results:
name: "All Tests: Safari (stable)"
needs: check-workflow-run
# We need always() here to then check for success/skipped from the
# dependency, as otherwise the skip cascades. See
# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs.
if: |
# We need always() here to then check for success/skipped from the dependency, as otherwise
# the skip cascades. See
# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs.
always() &&
(needs.check-workflow-run.result == 'success' || needs.check-workflow-run.result == 'skipped') &&
(github.event_name != 'workflow_run' || fromJSON(needs.check-workflow-run.outputs.updated-refs)[0] != null)
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/safari_technology_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
safari-technology-preview-results:
name: "All Tests: Safari Technology Preview"
needs: check-workflow-run
# We need always() here to then check for success/skipped from the
# dependency, as otherwise the skip cascades. See
# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs.
if: |
# We need always() here to then check for success/skipped from the dependency, as otherwise
# the skip cascades. See
# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-jobs-in-a-workflow#defining-prerequisite-jobs.
always() &&
(needs.check-workflow-run.result == 'success' || needs.check-workflow-run.result == 'skipped') &&
(github.event_name != 'workflow_run' || fromJSON(needs.check-workflow-run.outputs.updated-refs)[0] != null)
Expand Down

0 comments on commit 9326ce5

Please sign in to comment.