Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [g-m]* from monorail results #819

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Conversation

stephenmcgruer
Copy link
Contributor

See #798 for methodology

@stephenmcgruer stephenmcgruer added the do not merge yet Disable auto-merge label Feb 3, 2021
html-media-capture/META.yml Outdated Show resolved Hide resolved
idle-detection/META.yml Outdated Show resolved Hide resolved
import-maps/data-driven/META.yml Outdated Show resolved Hide resolved
inert/META.yml Outdated Show resolved Hide resolved
input-events/META.yml Outdated Show resolved Hide resolved
media-source/dedicated-worker/META.yml Outdated Show resolved Hide resolved
mediacapture-record/META.yml Outdated Show resolved Hide resolved
mediacapture-streams/META.yml Outdated Show resolved Hide resolved
mediacapture-streams/META.yml Outdated Show resolved Hide resolved
mst-content-hint/META.yml Outdated Show resolved Hide resolved
@@ -10,3 +10,7 @@ links:
status: FAIL
- test: integration-point-4.html
status: FAIL
- product: chrome
url: https://crbug.com/1093840
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, even if turns out it's not the only cause of failure, it's still relevant.

@@ -102,3 +102,15 @@ links:
subtest: 'MediaSource interface: attribute onsourceclose'
- test: idlharness.window.html
subtest: 'MediaSource interface: mediaSource must inherit property "onsourceclose" with the proper type'
- product: chrome
url: https://crbug.com/641121
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks likely relevant, the test failure is about event order and issue 641121 is about state change order.

@@ -11,3 +11,7 @@ links:
subtest: IntersectionObserverEntry interface object length
- test: idlharness.window.html
subtest: 'IntersectionObserver interface: observer must inherit property "thresholds" with the proper type'
- product: chrome
url: https://crbug.com/870947
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this one. This bug could be turned into something more descriptive since there's only a single subtest failure, but it's the right bug.

@foolip
Copy link
Member

foolip commented Feb 3, 2021

@stephenmcgruer there are test failures so I'll leave this to you.

@stephenmcgruer stephenmcgruer removed the do not merge yet Disable auto-merge label Feb 5, 2021
@stephenmcgruer stephenmcgruer merged commit 731fa53 into master Feb 5, 2021
@stephenmcgruer stephenmcgruer deleted the smcgruer/g-m-monorail branch February 5, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants