Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css/*, excluding css/css-*, from monorail results #808

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

stephenmcgruer
Copy link
Contributor

See #798 for methodology

@stephenmcgruer stephenmcgruer added the do not merge yet Disable auto-merge label Feb 1, 2021
css/CSS2/cascade/META.yml Show resolved Hide resolved
css/CSS2/tables/META.yml Outdated Show resolved Hide resolved
css/cssom-view/META.yml Show resolved Hide resolved
css/cssom-view/META.yml Outdated Show resolved Hide resolved
css/cssom-view/META.yml Outdated Show resolved Hide resolved
css/filter-effects/animation/META.yml Outdated Show resolved Hide resolved
css/motion/parsing/META.yml Outdated Show resolved Hide resolved
css/selectors/META.yml Outdated Show resolved Hide resolved
@@ -22,3 +22,17 @@ links:
status: FAIL
- test: mix-blend-mode-mask.html
status: FAIL
- test: mix-blend-mode-blended-element-overflow-hidden-and-border-radius.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we also could have gotten these from TestExpectations, I found https://chromium.googlesource.com/chromium/src.git/+/5b7ecdb7b265a278367d9334656531c69bd4089b%5E%21/#F0 via the bug. But the bug is right.

- product: chrome
url: https://crbug.com/1065468
results:
- test: font-family-serialization-001.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another failure here (Serialization of quoted "<generic-family>") which might be more important than the webkit-prefixed stuff, but https://crbug.com/1065468 is relevant.

I think it'll just be too messy over time to try to ensure that every subtest is explicitly accounted for, so let's live with this imprecision.

css/geometry/META.yml Outdated Show resolved Hide resolved
@foolip foolip removed the do not merge yet Disable auto-merge label Feb 2, 2021
@github-actions github-actions bot merged commit a5c7e4e into master Feb 2, 2021
@github-actions github-actions bot deleted the smcgruer/css-other branch February 2, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants